On Sat, Jan 5, 2013 at 11:38 AM, Junio C Hamano <gits...@pobox.com> wrote:
> I personally do not think a wrapper with limited slots is a healthy
> direction to go.  Most places we use getenv() do not let the return
> value live across their scope, and those that do should explicitly
> copy the value away.  It's between validating that there is _no_ *env()
> calls in the codepath between a getenv() call and the use of its
> return value, and validating that there is at most 4 such calls there.
> The former is much easier to verify and maintain, I think.

I did not look carefully and was scared of 143 getenv calls. But with
about 4 calls, yes it's best to do without the wrapper.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to