Christian Couder <christian.cou...@gmail.com> writes: > On Sat, Apr 21, 2018 at 5:13 AM, Junio C Hamano <gits...@pobox.com> wrote: > >> @@ -388,6 +389,9 @@ int cmd_gc(int argc, const char **argv, const char >> *prefix) >> if (argc > 0) >> usage_with_options(builtin_gc_usage, builtin_gc_options); >> >> + if (prune_expire && parse_expiry_date(prune_expire, &dummy)) >> + die(_("Failed to parse prune expiry value %s"), >> prune_expire); > > Micronit: I thought we prefer error messages to start with a lower > case letter, like: > > die(_("failed to parse prune expiry value %s"), prune_expire);
Thanks. There is an existing "Failed..." already before the pre-context of this hunk, which I'll fix with a preliminary clean-up patch.