On Sun, Jan 06, 2013 at 12:29:33PM -0800, Junio C Hamano wrote: > Adam Spiers <g...@adamspiers.org> writes: > > > The documentation for the ALLOC_GROW API implicitly encouraged > > developers to use "ary" as the variable name for the array which is > > dynamically grown. However "ary" is an unusual abbreviation hardly > > used anywhere else in the source tree, and it is also better to name > > variables based on their contents not on their type. > > Sounds good. To follow "not type but contents", a further rewrite > with s/array/item/ is even better, no? > > I can obviously squash it in without resending, if you agree, or you > can point out why item[] is not a good idea and array[] is better.
I agree. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
