On Fri, Jun 15, 2018 at 12:48:52PM -0700, Junio C Hamano wrote: > Derrick Stolee <[email protected]> writes: > > >> ewah_clear() can become file-scope static, and > >> rlwit_discharge_empty() can be eliminated. I do not know if either > >> is worth doing, though. > > > > With Peff's patches, this is true. When I applied your diff to my > > patch alone we could not do that. > > Yeah, as I organized the patches on two topics in this order: > > jk/ewah-bounds-check (build on 'maint') > Peff's 1/3 > Peff's 4/3 > > ds/ewah-cleanup (build on top of the above) > 7 patches in this series > Peff's 2/3 > Peff's 3/3
Thanks, I wasn't sure if I should resend mine on top, but it looks like you've got it all organized already. > at the end, these two changes become possible. Again, I am not sure > if these are worth doing, so I'll leave it out of these two series, > at least for now. IMHO the extra cleanups you showed are worth doing. -Peff
