On Tue, Jun 19, 2018 at 09:46:16AM -0700, Junio C Hamano wrote: > Taylor Blau <[email protected]> writes: > > > Attached is a ``fresh start'' of my series to teach 'git grep --column'. > > Since the last time I sent this, much has changed, notably the semantics > > for deciding which column is the first when given (1) extended > > expressions and (2) --invert. > > ... > > In the future, I'd like to revisit this, since any performance gains > > that we _do_ make in this area are moot when we rescan all lines in > > show_line() with --color. > > Sounds like a plan. From a quick scan, it seems that this is > sufficiently different from the last round so I won't bother > rebuilding your "--only" series on top, and instead just drop those > two series from the older round and queue this as the new and > improved tb/grep-column topic.
Thank you. I recommend dropping the second series (tb/grep-only-matching) entirely for now. I will rebase that on top of this so that you can apply it later in the future with ease. I don't expect the parts of this series that affect that one to change much, but I'll hold off on rebasing it in general until this series is stable, hopefully soon. > Thanks. Thanks, Taylor
