On Tue, Jun 26, 2018 at 06:18:26AM -0400, Robert P. J. Day wrote:
>
> ENVIRONMENT
> GIT_CONFIG
> Take the configuration from the given file instead of
> .git/config. Using the "--global" option forces this to
> ~/.gitconfig. Using the "--system" option forces this to
> $(prefix)/etc/gitconfig.
>
> is the phrase "forces this to" really what you want to use here?
> maybe i misunderstand what this option does, doesn't it simply mean
> that it will use a different (specified) file from the default,
> depending on the context (local, global, system)?
>
> it just seems weird to say that the option "forces" the use of what
> are clearly the default files. thoughts?
I agree it's weird. I think it's trying to mean "behaves as if it was
set to", but with the additional notion that the command-line argument
would take precedence over the environment (which is our usual rule).
But then we should just say those things explicitly.
Just looking at mentions of GIT_CONFIG in that manpage and knowing the
history, I think:
- the environment section should say something like:
GIT_CONFIG
If set and no other specific-file options are given, behaves as
if `--file=$GIT_CONFIG` was provided on the command-line.
- possibly the manpage should mention that GIT_CONFIG is historical and
should not be used in new code (we could also consider an actual
deprecation period and removal of the feature, though aside from
documentation confusion I do not think it is hurting anyone)
- the description of --file should not mention it at all. Instead it
should reference the "FILES" section which describes the whole lookup
sequence
- mention of GIT_CONFIG should be dropped from the FILES section. We
don't want to point people towards using it. And if they come across
it in the wild, they can find it in the ENVIRONMENT section.
- references to "--global" should stop mentioning ~/.gitconfig,
since in a post-XDG world it could be elsewhere (they're better to
refer to the "--global" description or the FILES section)
- references to "--system" should stop mentioning $(prefix)/etc/gitconfig,
since it can be configured separately from the prefix (and in most
packaged builds which set prefix=/usr, $(sysconfdir) is not
$(prefix)/etc).
-Peff
