On 06/26, Antonio Ospite wrote: > Hi, > > this is version 2 of the series from > https://public-inbox.org/git/20180622162656.19338-1-...@ao2.it/ > > The .gitmodules file is not meant for arbitrary configuration, it should > be used only for submodules properties. > > Plus, arbitrary git configuration should not be distributed with the > repository, and .gitmodules might be a possible "vector" for that. > > The series tries to alleviate both these issues by moving the > 'config_from_gitmodules' function from config.[ch] to submodule-config.c > and making it private. > > This should discourage future code from using the function with > arbitrary config callbacks which might turn .gitmodules into a mechanism > to load arbitrary configuration stored in the repository. > > Backward compatibility exceptions to the rules above are handled by > ad-hoc helpers. > > Finally (in patch 6) some duplication is removed by using > 'config_from_gitmodules' to load the submodules configuration in > 'repo_read_gitmodules'. > > Changes since v1: > * Remove an extra space before an arrow operator in patch 2 > * Fix a typo in the commit message of patch 3: s/fetchobjs/fetchjobs > * Add a note in the commit message of patch 6 about checking the > worktree before loading .gitmodules > * Drop patch 7, it was meant as a cleanup but resulted in parsing the > .gitmodules file twice
Thanks for making these changes, this version looks good to me! -- Brandon Williams
