Re: [PATCH v4 1/4] rebase: start implementing it as a builtin

[Andrei Rybak]

On 2018-07-08 20:01, Pratik Karki wrote:
> +
> +static int use_builtin_rebase(void)
> +{
> +     struct child_process cp = CHILD_PROCESS_INIT;
> +     struct strbuf out = STRBUF_INIT;
> +     int ret;
> +
> +     argv_array_pushl(&cp.args,
> +                      "config", "--bool", "rebase.usebuiltin", NULL);
> +     cp.git_cmd = 1;
> +     if (capture_command(&cp, &out, 6))
> +             return 0;

Does strbuf out leak on return here?

> +
> +     strbuf_trim(&out);
> +     ret = !strcmp("true", out.buf);
> +     strbuf_release(&out);
> +     return ret;
> +}