Jonathan Nieder <jrnie...@gmail.com> writes:
> Torsten Bögershausen wrote:
>> - /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
>> + /^\s*[^#]\s*which\s+[-a-zA-Z0-9]+$/ and err 'which is not portable
>> (please use type)';
> Hmm. Neither the old version nor the new one matches what seem to
> be typical uses of 'which', based on a quick code search:
> if which sl >/dev/null 2>&1
> sl -l
> if test -x "$(which sl 2>/dev/null)"
> sl -l
Yes, these two misuses are what we want it to trigger on, so the
test is very easy to trigger and produce a false positive, but does
not trigger on what we really want to catch.
That does not sound like a good benefit/cost ratio to me.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html