Eric Sunshine <sunsh...@sunshineco.com> writes: > On Mon, Jul 16, 2018 at 11:51 AM Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> On Mon, 16 Jul 2018, Johannes Schindelin wrote: >> > > - git submodule add --force bogus-url submod && >> > > + git submodule add --force /bogus-url submod && >> > >> > This breaks on Windows because of the absolute Unix-y path having to be >> > translated to a Windows path: >> > >> > >> > https://git-for-windows.visualstudio.com/git/git%20Team/_build/results?buildId=12365&view=logs >> > >> > I could imagine that using "$(pwd)/bogus-url" (which will generate a >> > Windows-y absolute path on Windows) would work, though. >> >> Yes, this works indeed, see the patch below. Could you please squash it in >> if you send another iteration of your patch series? Junio, could you >> please add this as a SQUASH??? commit so that `pu` is fixed on Windows? > > Thanks for reporting and diagnosing. I wondered briefly if we could > get by with simply "./bogus-url" instead of having to use $(pwd), > however, "./bogus-url" gets normalized internally into an absolute > path, so $(pwd) is needed anyhow to make the test '"$bogus_url" = > "$(git config ...)"' check work. > > So, this SQUASH looks like the correct way forward. Hopefully, Junio > can just squash it so I don't have to flood the list again with this > long series.
The topic already has another dependent topic so rerolling or squashing would be a bit cumbersome. I'll see what I could do but it may not be until tomorrow's pushout.
