On Sat, Jul 21, 2018 at 6:07 AM Duy Nguyen <pclo...@gmail.com> wrote: > > However, I'm just concentrating on a beefy machine; it may be that v6 > > drastically outperforms v2 on weaker hardware? Can others measure a > > lower memory usage for v6 than v2? > > I'll try it with massif on linux.git, but this is a very weak laptop > (4GB) so it'll take a while....
OK massif reports are too big to upload so I only pastebin'd the peak memory snapshot. fix-v2 uses 1.449 MB [1] (M = 1000) while my patch uses 1.394 MB heap. The actual saving if we focus on packlist_alloc() is 599,147,916B - 544,691,628B = roughly 50 MB or 8%. It's not _that_ big saving, so if your test runs do not show significant speedups, then fix-v2 is probably a better option. [1] https://pastebin.com/8iDcm9M4 [2] https://pastebin.com/bXBjzPvN -- Duy
