Junio C Hamano wrote:
> Matthieu Moy <matthieu....@grenoble-inp.fr> writes:
>> Phil Hord <ho...@cisco.com> writes:
>>> Subject: [PATCH] rebase --preserve-merges keeps empty merge commits
>> I would rephrase it as
>>   rebase --preserve-merges: keep empty merge commits
>> we usually give orders in commit messages, not state facts (it's not
>> clear from the existing subject line whether keeping merge commit is the
>> new behavior or a bug that the commit tries to fix).
> Thanks for giving a concise rationale on our use of imperative mood.
> Phil, I think you meant to and forgot to sign-off; here is what I'll
> queue.
> Thanks.

Looks good.  Thanks for the help.


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to