René Scharfe <[email protected]> writes:
> Am 02.08.2018 um 18:54 schrieb Jeff King:
>> PS I actually would have made the rule simply "does it begin with a
>> '<'", which seems simpler still. If people accidentally write "<foo",
>> forgetting to close their brackets, that is a bug under both the
>> old and new behavior (just with slightly different outcomes).
>
> Good point.
Straying sideways into a tangent, but do we know if any locale wants
to use something other than "<>" as an enclosing braket around a
placeholder? This arg-help text, for example,
N_("refspec") without LIT-ARG-HELP
would be irritating for such a locale's translator, who cannot
defeat the "<>" that is hardcoded and not inside _()
s = literal ? "%s" : "<%s>";
that appear in parse-options.c::usage_argh().
Perhaps we should do _("<%s>") here? That way, the result would
hopefully be made consistent with
N_("<refspec>[:<expect>]") with LIT-ARG-HELP
which allows translator to use the bracket of the locale's choice.
