Nguyễn Thái Ngọc Duy <> writes:

> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.
> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
>               PROVE
>               VALGRIND
> +             PERF_LARGE_REPO
> +             PERF_REPEAT_COUNT
> +             PERF_REPO
>       ));

Wouldn't it be more futureproof to put simply PERF as an entry, and rely
on the leading-match logic

>       my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);

to allow all GIT_PERF variables?

Other than that, Ack.  I never noticed because I set mine through
config.mak, which goes to GIT-BUILD-OPTIONS.  Those options are not
exported, which means perl does not pick them up.  (That just took me
far too long to realize.)

Thomas Rast
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to