Am 11.08.2018 um 18:48 schrieb Jeff King:
And one I'm not sure about:

  - a read() error will now be quietly ignored; I guess we'd have to
    check ferror(fp) to cover this. I'm not sure if it matters.

I'm not sure, either.  It would catch media errors or file system
corruption, right?  Sounds useful, actually.  We should check the other
callers of strbuf_getline and friends as well, though, as reporting such
errors seems to be omitted in most cases:

        $ git grep strbuf_getline | wc -l
        $ git grep ferror | wc -l


Reply via email to