> [1/7]: for_each_*_object: store flag definitions in a single location
> [2/7]: for_each_*_object: take flag arguments as enum
> [3/7]: for_each_*_object: give more comprehensive docstrings
> [4/7]: for_each_packed_object: support iterating in pack-order
> [5/7]: t1006: test cat-file --batch-all-objects with duplicates
> [6/7]: cat-file: rename batch_{loose,packed}_object callbacks
> [7/7]: cat-file: support "unordered" output for --batch-all-objects
Thanks for laying all the patches out so cleanly! All of them are:
Reviewed-by: Jonathan Tan <jonathanta...@google.com>
Normally I would re-explain the patches to demonstrate that I understand
them, but in this case, I think they are simple enough - patches 1, 2,
3, and 6 are refactorings that I agree with, patch 5 just makes a test
more comprehensive, and patches 4 and 7 do what their commit messages
say.
Stefan brought up the concern that cache.h is increasing in size, but I
agree with the patch as written that it's probably best that we
centralize all the flags somewhere, and we can deal with the location in
a future patch.
