Jeff King <p...@peff.net> writes: >> In the longer term we may want to accept size_t as parameter for >> clarity (even though we know that a sideband message we are painting >> typically would fit on a line on a terminal and int is sufficient). >> Write it down as a NEEDSWORK comment. > > This "typically" made me nervous about what happens in the non-typical > case, but I think we can say something even stronger: the length comes > from a pktline, so the maximum is less than 16 bits. I wondered if we > might ever call this on the accumulated string from multiple sidebands, > but it doesn't look like it.
I think a sideband packet may be split on one but not the other codepath to result in multiple calls, but I do not think we coalesce them together, so I agree that int is sufficient.
