g...@jeffhostetler.com wrote: > From: Jeff Hostetler <jeffh...@microsoft.com> > > Teach the Makefile to take STRUCTURED_LOGGING=1 variable to > compile in/out structured logging feature. > > Signed-off-by: Jeff Hostetler <jeffh...@microsoft.com> > --- > Makefile | 8 ++++++++ > structured-logging.c | 9 +++++++++ > structured-logging.h | 13 +++++++++++++ > 3 files changed, 30 insertions(+) > create mode 100644 structured-logging.c > create mode 100644 structured-logging.h
This should probably be squashed with a later patch (e.g., patch 3). When taken alone, it produces [...] > --- /dev/null > +++ b/structured-logging.c > @@ -0,0 +1,9 @@ > +#if !defined(STRUCTURED_LOGGING) > +/* > + * Structured logging is not available. > + * Stub out all API routines. > + */ > + > +#else > + > +#endif which is not idiomatic (for example, it's missing a #include of git-compat-util.h, etc). Thanks, Jonathan
