On Tue, Sep 4, 2018 at 5:08 PM Ævar Arnfjörð Bjarmason <[email protected]> wrote: > > On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila <[email protected]> wrote: > > Your commit message says "dangling dot"... > > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > > index b56028ba9d..a011abfd7c 100644 > > --- a/builtin/submodule--helper.c > > +++ b/builtin/submodule--helper.c > > @@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct > > cache_entry *list_item, > > printf(_("Entering '%s'\n"), displaypath); > > > > if (info->argv[0] && run_command(&cp)) > > - die(_("run_command returned non-zero status for %s\n."), > > + die(_("run_command returned non-zero status for %s"), > > ...but here and below you're also removing the newline. Is this > intended, and does it work as desired afterwards? I.e. were we just > ignoring the \n?
die() already adds \n, so this \n adds a blank line. Since this is an error, not part of any fancy text layout construction, I think the \n here could (and should) be removed -- Duy
