> > Ben, do you have an idea? > > > > I'll take a look as soon as I can (and at the other fsmonitor test issue Ævar > sent email about) but it may be a few days before I get a chance. > > I haven't had a chance to look into this yet but here are a couple of SWAG's > I'd start with: >
> is it possible that "git mv" is triggering it early, making a change, and > then updating the index with stale fsmonitor data? This is exactly what is happening. Thanks for describing the situation precisely. > I wonder if there is a missing call to mark_fsmonitor_invalid() in the "git > mv" codepath somewhere. > > refresh_fsmonitor() only runs once per git command Just naively adding mark_fsmonitor_invalid doesn't work, as then we have a sequence of fsmonitor process '/u/git/t/t7519/fsmonitor-all' returned success mark_fsmonitor_clean '.gitmodules' mark_fsmonitor_invalid '.gitmodules' write fsmonitor extension successful and the marking invalid doesn't seem to override the first mark as valid ? > > Sorry, I'll look as soon as I can. > > Ben Thanks! Stefan
