On 2018-09-23 06:23 PM, Jeff King wrote: > On Sun, Sep 23, 2018 at 05:56:03PM -0700, Stas Bekman wrote: > >>> You probably want "--ext-diff", not "--textconv". >> [...] >> Would it be safe to ask the maintainer of the application to include >> both --textconv and --ext-diff in that 'git diff-tree' call? I only need >> the latter, but someone needed --textconv there as it's in the code. > > I think so. The main reason that they are not the default for plumbing > commands such as diff-tree is that the output may be quite surprising to > anything trying to parse the output. Using --textconv will always > produce a diff, but one that may not be applied to the original content. > Using --ext-diff may produce output that doesn't even look like a diff, > though in practice they often do. > >> This is for this package: >> https://github.com/rsmmr/git-notifier > > It looks like the output is meant to be read by humans, so yeah, I think > it would be fine (and preferred) to enable both.
Fantastic. Thank you so much, Jeff. -- ________________________________________________ Stas Bekman <'))))>< <'))))>< https://stasosphere.com https://chestofbooks.com https://experientialsexlab.com https://stason.org https://stasosphere.com/experience-life/my-books
