Matthew DeVore <[email protected]> writes:
> I screwed up by putting the positional argument *after* the
> redirection. Sorry for the mix-up. This is interestingly syntactically
> valid, though bad stylistically. Here is an inter-diff:
Thanks for being careful. Except for a rather idiomatic
echo >&2 message ...
which has redirection at the beginning to emphasize that the output
goes to the standard error stream, I do agree with your "stylistic"
choice of keeping the redirection at the end.
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> index eeedd1623..6ff614692 100755
> --- a/t/t5616-partial-clone.sh
> +++ b/t/t5616-partial-clone.sh
> @@ -35,7 +35,7 @@ test_expect_success 'setup bare clone for server' '
> test_expect_success 'do partial clone 1' '
> git clone --no-checkout --filter=blob:none
> "file://$(pwd)/srv.bare" pc1 &&
>
> - git -C pc1 rev-list --quiet --objects --missing=print >revs HEAD &&
> + git -C pc1 rev-list --quiet --objects --missing=print HEAD >revs &&
> awk -f print_1.awk revs |
> sed "s/?//" |
> sort >observed.oids &&
> @@ -93,8 +93,8 @@ test_expect_success 'verify diff causes dynamic
> object fetch' '
> test_expect_success 'verify blame causes dynamic object fetch' '
> git -C pc1 blame origin/master -- file.1.txt >observed.blame &&
> test_cmp expect.blame observed.blame &&
> - git -C pc1 rev-list --quiet --objects --missing=print >observed \
> - master..origin/master &&
> + git -C pc1 rev-list --quiet --objects --missing=print \
> + master..origin/master >observed &&
> test_line_count = 0 observed
> '
