Matthew DeVore <[email protected]> writes:
> On Tue, 23 Oct 2018, Junio C Hamano wrote:
>
>> Not really. We were already doing a controlled failure via die(),
>> so these two tests would not have caught the problem in the code
>> before the fix in this patch.
>>
>
> BUG is apparently considered a "wrong" failure and not a controlled one
> by test_must_fail. I just double-checked that the tests fail without
> this patch.
Ah, I was testing a wrong codepath. Yes, it does call BUG("..."),
which is a prettier-looking abort(), but I somehow thought it was
doing die("BUG: ...").
In any case, thanks for the fix.
