Re: [PATCH v2 5/5] pretty: add support for separator option in %(trailers)

[Junio C Hamano]

Anders Waldenborg <and...@0x63.nu> writes:

> +                             if (opts->separator && first_printed)
> +                                     strbuf_addbuf(out, opts->separator);
>                               if (opts->no_key)
> -                                     strbuf_addf(out, "%s\n", val.buf);
> +                                     strbuf_addf(out, "%s", val.buf);

Avoid addf with "%s" alone as a formatter; instead say

        strbuf_addstr(out, val.buf);

cf. contrib/coccinelle/strbuf.cocci