Just to note, the proposals so far don't prevent a "smart-ass" function from 
freeing the buffer when it's called underneath the use/release scope, as in:

with_commit_buffer(commit); {
} done_with_commit_buffer(commit);

walk_rev_tree_or_something() might need to read commits to do its thing, and it 
could still choose to free their buffers (as in rev-list.c finish_commit()). If 
those commits includes the one being "retained", the call to fn2 will still see 
NULL despite it being in a 'protected scope'.

Are the objections to using a reference count?

Jonathon Mah

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to