On Tue, Nov 13, 2018 at 4:32 PM Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > I won't have time to finish this today, as noted in > https://public-inbox.org/git/874lcl2e9t....@evledraar.gmail.com/ > there's a pretty major bug here in that we're now writing out literal > sharedindex_XXXXXX files.
It's not the end of the world because create_tempfile opens with O_EXCL so if two processes try to create it at the same time, one will fail, but no corruption or such. > Obviously that needs to be fixed, and the fix is trivial, I can use > another one of the mks_*() functions with the same mode we use to > create the index. > > But we really ought to have tests for the bug this patch introduces, > and as noted in the E-Mail linked above we don't. > > So hopefully Duy or someone with more knowledge of the split index > will chime in to say what's missing there... I don't have any bright idea how to catch the literal _XXXXX file. It's a temporary file and will not last long enough for us to verify unless we intercept open() calls with LD_PRELOAD. -- Duy
