Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes:

> ---
>  builtin/branch.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Forgot to sign-off?

Is this a real problem?

I do not see it particularly wrong to succeed after deleting 0 or
more given branch names.

>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index 873f624..50fcacc 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -837,9 +837,11 @@ int cmd_branch(int argc, const char **argv, const char 
> *prefix)
>               colopts = 0;
>       }
>  
> -     if (delete)
> +     if (delete) {
> +             if (!argc)
> +                     die(_("branch name required"));
>               return delete_branches(argc, argv, delete > 1, kinds, quiet);
> -     else if (list) {
> +     } else if (list) {
>               int ret = print_ref_list(kinds, detached, verbose, abbrev,
>                                        with_commit, argv);
>               print_columns(&output, colopts, NULL);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to