From: Pedro de Lyra <[email protected]>

Signed-off-by: Pedro de Lyra <[email protected]>
---
According to POSIX manual pages, the open() system call's mode argument 
specifies the file mode bits to be applied when a new file is created. If 
neither O_CREAT nor O_TMPFILE is specified, then mode is ignored. So I guess 
that 0 argument only confuses the reader.
 setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup.c b/setup.c
index 1be5037f1..d4fd14bb7 100644
--- a/setup.c
+++ b/setup.c
@@ -1228,7 +1228,7 @@ const char *resolve_gitdir_gently(const char *suspect, 
int *return_error_code)
 /* if any standard file descriptor is missing open it to /dev/null */
 void sanitize_stdfds(void)
 {
-       int fd = open("/dev/null", O_RDWR, 0);
+       int fd = open("/dev/null", O_RDWR);
        while (fd != -1 && fd < 2)
                fd = dup(fd);
        if (fd == -1)
-- 
2.17.1

Reply via email to