Commit fed2369 (git-p4: Search for parent commit on branch creation,
2012-01-25) uses temporary branches to help find the parent of a
new p4 branch.  The temp branches are of the form "git-p4-tmp/%d"
for some p4 change number.  Mistakenly, this string was made
using os.path.join() instead of just string concatenation.  On
windows, this turns into a backslash (\), which is not allowed in
git branch names.

Reported-by: Casey McGinty <>
Signed-off-by: Pete Wyckoff <>
--- | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ b/
index 2da5649..fb77c56 100755
--- a/
+++ b/
@@ -2687,7 +2687,7 @@ class P4Sync(Command, P4UserMap):
                         blob = None
                         if len(parent) > 0:
-                            tempBranch = os.path.join(self.tempBranchLocation, 
"%d" % (change))
+                            tempBranch = "%s/%d" % (self.tempBranchLocation, 
                             if self.verbose:
                                 print "Creating temporary branch: " + 
                             self.commit(description, filesForCommit, 

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to