On Mon, Dec 10, 2018 at 7:47 PM Stefan Beller <[email protected]> wrote:
>
> On Sun, Dec 9, 2018 at 2:25 AM Nguyễn Thái Ngọc Duy <[email protected]> wrote:
> >
> > Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]>
> > ---
> > bisect.c | 3 ++-
> > builtin/config.c | 3 ++-
> > builtin/push.c | 4 +++-
> > convert.c | 3 ++-
> > credential-cache--daemon.c | 3 ++-
> > diff.c | 6 ++++--
> > git.c | 3 ++-
> > imap-send.c | 3 ++-
> > remote-curl.c | 3 ++-
> > sequencer.c | 6 ++++--
> > string-list.c | 3 ++-
> > t/helper/test-sigchain.c | 3 ++-
> > transport-helper.c | 3 ++-
> > url.c | 3 ++-
> > userdiff.c | 3 ++-
> > 15 files changed, 35 insertions(+), 17 deletions(-)
>
> Can you say more about how you found these?
I was updating diff.c (65 patches coming soon!) and found one function
that triggered me. "git grep '^static.*) {$'" caught most of them. A
bit more regex got some more but I don't even know if I have caught
them all.
> (Are these all of them, or did you look through some subset of files?)
I left compat and xdiff directories out if I remember correctly.
> Or did you use a formatting tool?
Unfortunately no. Perhaps clang-format can do it? I didn't try.
--
Duy
