On Wed, Dec 12, 2018 at 10:14:53AM -0800, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <dsto...@microsoft.com> > > The new test_oid machinery in the test library requires reading > some information from t/oid-info/hash-info and t/oid-info/oid. > The shell logic that reads from these files is sensitive to CRLF > line endings, causing a problem when the test suite is run on a > Windows machine that converts LF to CRLF. > > Exclude the files in this folder from this conversion. > > Signed-off-by: Derrick Stolee <dsto...@microsoft.com> > --- > .gitattributes | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitattributes b/.gitattributes > index acf853e029..3738cea7eb 100644 > --- a/.gitattributes > +++ b/.gitattributes > @@ -13,3 +13,4 @@ > /Documentation/gitk.txt conflict-marker-size=32 > /Documentation/user-manual.txt conflict-marker-size=32 > /t/t????-*.sh conflict-marker-size=32 > +/t/oid-info/* eol=lf
Yeah, this seems like a sensible thing to do. I assumed the shell on Windows would read data as text files, not as binary files. It's kinda hard for me as a non-Windows user to predict what will need CRLF endings and what will need LF endings with Git on Windows. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
