On Thu, Dec 27, 2018 at 03:46:10PM -0800, Erin Dahlgren wrote:
> > Heh, I should learn to cut and paste better. This should be:
> >
> > if (!nongit_ok || !*nongit_ok)
> >
> > (which comes from the current code).
>
> Yep, but I think we can benefit from De Morgan's law here, where:
>
> (!nongit_ok || !*nongit_ok) == (!(nongit_ok && *nongit_ok))
>
> PATCH v3 (just sent) uses that transformation like this:
>
> if (nongit_ok && *nongit_ok) {
> ... startup_info->has_repository = 0;
> } else {
> // !nongit_ok || !*nongit_ok
> .. startup_info->has_repository = 1;
> }
>
> Because IMHO (nongit_ok && *nongit_ok) is easier to read and reason
> about. Added brief comments as well.
Ah yes, that's much better.
-Peff
