On 1/17/2019 10:09 AM, Derrick Stolee wrote:

The code itself looks good, I just need to double-check the performance numbers.

I tested this patch on our VFS-specific version using five "prefetch packs".

Before: 22.61 s (avg)
After: 22.18 s (avg)

Improvement: 2%

The error rate among the samples is very low (~.15 s) so this result is significant.

Considering that we are writing 4.4 million commits -- many more than the objects in the packs that we are reading -- this is an excellent improvement!

Thanks!
-Stolee

Reply via email to