> On Jan 30, 2019, at 04:42, Johannes Schindelin <johannes.schinde...@gmx.de>
> wrote:
>
> Hi Jeremy,
>
> On Wed, 30 Jan 2019, Jeremy Huddleston Sequoia wrote:
>
>>> On Jan 30, 2019, at 03:33, Eric Sunshine <sunsh...@sunshineco.com> wrote:
>>>
>>> On Tue, Jan 29, 2019 at 3:11 PM Jeremy Huddleston Sequoia
>>> <jerem...@apple.com> wrote:
>>>> This was causing problems with ppc/sha1ppc.S
>>>
>>> What problems, exactly?
>>
>> The file is ignored, but it shouldn't be.
>
> As somebody who sometimes (pretty rarely, but definitely more than once a
> year) generates the assembler files to have a deeper look, I really
> understand why *.s is ignored, and I think it should stay ignored.
>
> What you probably want instead is
>
> # Accommodate for case-insensitive filesystems where *.s would catch
> !ppc/sha1ppc.S
>
> after the `*.[aos]` line.
Thanks for the suggestion. I didn't know that was possible with .gitignore.
That's a much better solution. I was expecting this to just stay in our series
as upstreamable, but I'm glad you pointed this out. I got to learn something
new and offload a patch. Thanks!
I'll now be able include this in my followup series of patches that I think can
be upstreamed! =)
> Ciao,
> Johannes
>
>>
>>>
>>>> Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com>
>>>> ---
>>>> diff --git a/.gitignore b/.gitignore
>>>> @@ -195,7 +195,7 @@
>>>> -*.[aos]
>>>> +*.[ao]
>>
>>
