> -----Original Message----- > From: Junio C Hamano <jch2...@gmail.com> On Behalf Of Junio C Hamano > Sent: Friday, February 15, 2019 12:50 PM > To: Ben Peart <peart...@gmail.com> > Cc: Ramsay Jones <ram...@ramsayjones.plus.com>; git@vger.kernel.org; > Ben Peart <ben.pe...@microsoft.com>; Kevin Willford > <kewi...@microsoft.com>; sand...@crustytoothpaste.net > Subject: Re: [PATCH v2] read-cache: add post-indexchanged hook > > Ben Peart <peart...@gmail.com> writes: > > > On 2/14/2019 3:33 PM, Junio C Hamano wrote: > >> Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> > >>> On 14/02/2019 14:42, Ben Peart wrote: > >>>> From: Ben Peart <benpe...@microsoft.com> > >>>> > >>>> Add a post-indexchanged hook that is invoked after the index is > >>>> written in > >>> > >>> s/post-indexchanged/post-index-changed/ > >> > >> Good. I wasn't paying close attention to the previous round, but is > >> that the only name-related bikeshedding? I somehow feel that without > >> s/changed/change/ the name does not roll well on my tongue and does > >> not sit well together with existing ones like post-receive (which is > >> not post-received). I dunno. > >> > >> Will queue. Thanks. > > > > Would you like me to submit another version with the above spelling > > corrections in the commit message or is it easier to fix it up > > yourself? > > I've already done s/indexchanged/index-changed/ before queuing (there > was only one IIRC in the log message), and also the 'optimize' typofix. > > I didn't do anything about dropping 'd' at the end, as I haven't heard any > feedback on that from anybody yet. >
I'm ok with either. post-index-changed sounded clearer to me but you're right, none of the other hooks use the post tense. I've submitted one with 'post-index-change' - feel free to keep/user either. > >>>> do_write_locked_index(). > >>>> > >>>> This hook is meant primarily for notification, and cannot affect > >>>> the outcome of git commands that trigger the index write. > >>>> > >>>> The hook is passed a flag to indicate whether the working directory > >>>> was updated or not and a flag indicating if a skip-worktree bit > >>>> could have changed. These flags enable the hook to optmize its > >>>> response to the > >>> > >>> s/optmize/optimize/ > >>> > >>> ATB, > >>> Ramsay Jones
