On Wed, 6 Mar 2019, Junio C Hamano wrote:
> Jeff King <[email protected]> writes:
>
> > ... I do think the documentation should recommend "now". Possibly
> > builtin/gc.c should be smarter about recognizing "all" in the
> > conditional you quoted, too, though I don't know that it's all
> > that important (especially if we tweak the documentation).
>
> Yup, as the placeholder for the value is labeled as "<date>", "now"
> would be the one we should be encouraging.
i can submit an obviously trivial patch for that -- i can see in
date.c the equally valid alternatives:
int parse_expiry_date(const char *date, timestamp_t *timestamp)
{
int errors = 0;
if (!strcmp(date, "never") || !strcmp(date, "false"))
*timestamp = 0;
else if (!strcmp(date, "all") || !strcmp(date, "now"))
... snip ...
is the preference to simply list both alternatives, or to
*encourage* the more intuitive "now" and "never" values while politely
deprecating the others? the impression i get is the latter.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
