On Sun, 17 Mar 2019 at 13:50, Nguyễn Thái Ngọc Duy <[email protected]> wrote:
>
> Add backticks where we have none, replace single quotes with backticks
> and replace double-quotes. Drop double-quotes from nested constructions
> such as `"@{-1}"`. Add a missing possessive apostrophe after the word
> "submodules" while at it.

Assuming you move those "submodules" hunks from an earlier commit, this
last part needs some tweaking since you're not adding a "'", but you
actually rephrase the docs to avoid a buggy AsciiDoc rendering. (And if
a while-at-it needs too much explaining, maybe just skip it altogether?
I dunno.)

Other than some things appearing in the wrong commit(?), this matches
the "how about this?" I sent for v3 and our discussion of that.



Martin

Reply via email to