gree...@obbligato.org writes:

> Junio C Hamano <gits...@pobox.com> writes:
>
>> "David A. Greene" <gree...@obbligato.org> writes:
>>
>>> +test_create_commit() (
>>> +   repo=$1
>>> +   commit=$2
>>> +   cd "$repo"
>>> +   mkdir -p "$(dirname "$commit")"
>>> +   echo "$commit" > "$commit"
>>
>> Style.
>
> I need a little more explanation.  :)  Is there a style guide somewhere?

Documentation/CodingGuidelines?

>
>>> +   git add "$commit"
>>> +   git commit -m "$commit"
>>> +)
>>
>> Very nice, but don't we want to check for possible errors in any of
>> the above commands?
>
> I'll fix that.  :)
> ...
> Ok.  I'll rework this.

Thanks.

I also think it would be a good idea for you to learn to push back
to the original authors; fixing problems in patches by others, while
is a good way to learn how their thinking process went, is not
necessarily fun.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to