On Mon, Apr 01, 2019 at 12:01:04AM +0200, Andrei Rybak wrote:
> diff --git a/mailinfo.c b/mailinfo.c
> index b395adbdf2..4ef6cdee85 100644
> --- a/mailinfo.c
> +++ b/mailinfo.c
> @@ -701,6 +701,13 @@ static int is_scissors_line(const char *line)
> c++;
> continue;
> }
> + if (!memcmp(c, "✂", 3)) {
This character is tiny. Please add a comment that it's supposed to be
a Unicode scissors character.
Should we worry about this memcmp() potentially reading past the end
of the string when 'c' points to the last character?
> + in_perforation = 1;
> + perforation += 3;
> + scissors += 3;
> + c++;
Here you should jump past the three byte long Unicode character, so
this should be c += 2.
> + continue;
> + }
> in_perforation = 0;
> }
>