Hi Junio, Junio C Hamano <[email protected]> 於 2019年5月15日 週三 上午8:48寫道： > > 林自均 <[email protected]> writes: > > > I was not talking about the messages in the editor session. I was > > talking about "git commit" without "git add" anything. > > > > For example: > > > > ``` > > $ touch newfile.txt > > $ git commit > > On branch master > > Untracked files: > > newfile.txt > > > > nothing added to commit but untracked files present > > ``` > > > > My current patch is trying to add an empty line between > > "Untracked files:" and "newfile.txt". > > I do not think that one is paged, so if you ask me, I'd say we > shouldn't add an extra blank there. Is that message also reused in > the editor session, or do two different codepaths produce a similar > looking message, one for the above case direct to the terminal and > the other for the editor session?
The messages produced in wt-status.c seem to be reused in both terminal and editor session. When I tried to modify the messages in terminal, the ones in editor session will also be modified accordingly. By the way, my new patch to remove extra blank line is here: https://github.com/gitgitgadget/git/pull/196 I am still waiting for someone to comment "/allow johnlinp". > > But again... > > >> At the same time, I think I've been happy enough with the current > >> output from both commands, so if you let me bikeshed freely, I'd > >> probably pick "let's not change anything then" ;-) >
