On Wed, Aug 07, 2019 at 01:15:25PM +0200, René Scharfe wrote: > Signed-off-by: René Scharfe <l....@web.de> > --- > Patch generated with --function-context for easier review. > > The plugged leak was added by a10a17877b (for_each_alternate_ref: > replace transport code with for-each-ref, 2017-02-08) and showed up in > 709dfa6990 (object-store.h: move for_each_alternate_ref() from > transport.h, 2019-07-01), where it caught my eye, belatedly.
Thanks, the patch obviously looks good (though I wouldn't be sad for some of your digging above to go into the commit message). I had a vague feeling that we had seen this particular leak before (and presumably the fix fell through the cracks). But I couldn't find it on the list. I think after a while these strbuf_getline() leaks all start to look the same. :) -Peff