On Sat, Sep 07, 2019 at 02:56:36PM -0400, Taylor Blau wrote: > So, the patch here looks obviously correct, and I don't think it needs a > test or anything like that... besides: what is there to test? :).
There's no functional change, so as long as this has coverage in the regular suite (and I think it does), there's no point in adding a new functional test. However, it may make sense to get some coverage of commit graphs in the perf suite, so that we could detect regressions there. I think that would make sense as a separate series, though, not attached to this particular fix. (It would also be cool if the perf suite could record peak memory usage, but that would take a fair bit of refactoring). -Peff