Jeff King <p...@peff.net> writes: > On Sun, Sep 08, 2019 at 06:47:11PM -0700, Stephen P. Smith wrote: > >> Remove the reference to the GIT_TEST_DATE_NOW which is done in date.c. >> The intialization of variable x with the value from GIT_TEST_DATE_NOW >> is unneeded since x is initalized by skip_prefix(). > > It took me a minute to understand what this second sentence meant. I'd > have actually expected "x" to go away, looking at the diff context. > > Maybe a more clear explanation would be: We can't get rid of the "x" > variable, since it serves as a generic scratch variable for parsing > later in the function. > > (I'd also probably have just rolled this into patch 1, but I'm OK with > it either way).
Thanks for saying everything ;-) I have nothing to add.