On 22/10/19 09:46AM, Bert Wesarg wrote: > On Mon, Oct 21, 2019 at 9:35 PM Johannes Sixt <j...@kdbg.org> wrote: > > > > Am 21.10.19 um 11:16 schrieb Bert Wesarg: > > > Dear Pratyush, > > > > > > I just noticed that the 'Revert Last Hunk' menu entry is enabled in > > > the stage-list. But I think it should be disabled, like the 'Revert > > > Hunk' and 'Revert Line' menu entry. > > > > > > Can you confirm this? > > > > Technically, it need not be disabled because the hunk being reverted > > does not depend on the contents of any of diffs that can be shown. > > > > The entry should be disabled if reverting the stored hunk fails. But to > > know that, it would have to be tried: the file could have been edited > > since the hunk was generated so that the reversal of the hunk fails. > > But the "Undo" changes the worktree not the stage, sure it indirectly > also changes the view of the staged content, but that is only a
I don't think the "Undo Last Revert" should affect "staged content" in any way. In fact, if it does, it is probably a bug. A more detailed reply is to your other email. I just wanted to clarify that an undo _should not_ affect the staged content. > secondary effect. As I only can revert in the worktree list, I think > we should be consistent and also only allow to undo the revert in the > worktree list. > > And I think it is independent of 'does the undo apply at all' question. -- Regards, Pratyush Yadav
