Mike Gorchak <mike.gorchak....@gmail.com> writes:
> Do not compare time_t (less comparison) with -1. If time_t
> is unsigned this leads to always true comparison.
> Signed-off-by: Mike Gorchak <mike.gorchak....@gmail.com>
> date.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/date.c b/date.c
> index 57331ed..1ac28e5 100644
> --- a/date.c
> +++ b/date.c
> @@ -383,7 +383,7 @@ static int is_date(int year, int month, int day,
> struct tm *now_tm, time_t now,
> * sense to specify timestamp way into the future. Make
> * sure it is not later than ten days from now...
> - if (now + 10*24*3600 < specified)
> + if ((specified != -1) && (now + 10*24*3600 < specified))
> return 0;
> tm->tm_mon = r->tm_mon;
> tm->tm_mday = r->tm_mday;
This is good enough band-aid for now (as it won't change the
semantics for anybody), but I suspect in the longer term we would
want to pick a different mechanims to signal errors, so that we can
specify timestamp that is before 1970.
Thanks, will queue.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html