On 10/03/13 00:00, Jonathan Nieder wrote:

Michael Fallows wrote:

--- a/git.c
+++ b/git.c
@@ -316,8 +316,7 @@ static void handle_internal_command(int argc, const char 
                { "check-ignore", cmd_check_ignore, RUN_SETUP | NEED_WORK_TREE 
                { "check-ref-format", cmd_check_ref_format },
                { "checkout", cmd_checkout, RUN_SETUP | NEED_WORK_TREE },
-               { "checkout-index", cmd_checkout_index,
-                       RUN_SETUP | NEED_WORK_TREE},
+               { "checkout-index", cmd_checkout_index, RUN_SETUP | 

This wrapped line was introduced a while ago (4465f410, checkout-index
needs a working tree, 2007-08-04).  It was the first line to wrap, but
it was also the longest line at the time.

Now the longest line is

                { "merge-recursive-theirs", cmd_merge_recursive, RUN_SETUP | 

(94 columns), so you are right that consistency would suggest dropping
the line wrapping for checkout-index.

But I find it hard to convince myself that alone is worth the churn.
In what context did you notice this?  Is the intent to help scripts to
parse the commands[] list, or to manipulate it while preserving
formatting to avoid distractions?  Did you notice the broken line
while reading through and get distracted, or did some syntax
highlighting tool notice the oddity, or something else?

Hope that helps,

I do agree with you it does seem like a silly small change in the context of the project! I noticed it when reading through the source code (I felt working with git is nice but why not see what makes it tick). I will admit also, have never contributed to git and my C is nowhere near the standard worthy of any real contribution so this was also a step for me to see exactly how the world of patch contribution works too :D.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to