fread returns the number of items read, with no special error return.

Commit 98f85ff (reflog: add for_each_reflog_ent_reverse() API -
2013-03-08) introduced a call to fread which checks for an error with
"nread < 0" which is tautological since nread is unsigned.  The correct
check in this case (which tries to read a single item) is "nread != 1".

Signed-off-by: John Keeping <>
I found this because Clang generated a tautological comparison warning
on this line.

 refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/refs.c b/refs.c
index 56cc93d..de2d8eb 100644
--- a/refs.c
+++ b/refs.c
@@ -2399,7 +2399,7 @@ int for_each_reflog_ent_reverse(const char *refname, 
each_reflog_ent_fn fn, void
                        return error("cannot seek back reflog for %s: %s",
                                     refname, strerror(errno));
                nread = fread(buf, cnt, 1, logfp);
-               if (nread < 0)
+               if (nread != 1)
                        return error("cannot read %d bytes from reflog for %s: 
                                     cnt, refname, strerror(errno));
                pos -= cnt;

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to