Junio C Hamano <gits...@pobox.com> writes:

>> +    if (advice_status_hints) {
>> +    }
>> +    if (advice_status_hints)
>> +            status_printf_ln(s, color,
>> +                    _("  (use \"git revert --abort\" to cancel the revert 
>> operation)"));
>
> Why not a single conditional? i.e.
>
>       if (advice_status_hints) {
>               if unmerged
>                       fix and continue
>               else
>                       say continue
>               you can also say abort
>       }

Oops, you're right. I wrote the code mostly with cut-and-past + edit
from other functions, and didn't notice the obvious refactoring
opportunity.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to