Felipe Contreras <felipe.contre...@gmail.com> writes:

> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com>
> ---
>
> Actually, now that we are on it. After applying my latest patch series, this 
> makes sense.

Yes, this is way easier to read.

>
>  builtin/log.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/builtin/log.c b/builtin/log.c
> index fab7998..7cf9277 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -1058,12 +1058,10 @@ static char *find_branch_name(struct rev_info *rev)
>               else
>                       return NULL;
>       }
> -     if (0 <= positive) {
> -             ref = rev->cmdline.rev[positive].name;
> -             tip_sha1 = rev->cmdline.rev[positive].item->sha1;
> -     } else {
> +     if (positive < 0)
>               return NULL;
> -     }
> +     ref = rev->cmdline.rev[positive].name;
> +     tip_sha1 = rev->cmdline.rev[positive].item->sha1;
>       if (dwim_ref(ref, strlen(ref), branch_sha1, &full_ref) &&
>           !prefixcmp(full_ref, "refs/heads/") &&
>           !hashcmp(tip_sha1, branch_sha1))
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to