On Wed, Apr 10, 2013 at 04:22:57PM +0200, Torsten Bögershausen wrote:

> Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"
> This was because the regexp checking for duplicate numbers strips everything
> after the first "-" in the filename, including the prefix.
> As a result, 2 pathnames like
> "xxxx/contrib/remote-helpers/test-XX.sh" and
> "xxxx/contrib/remote-helpers/test-YY.sh"
> are both converted into
> "xxxx/contrib/remote", and reported as duplicate.
> Improve the regexp:
> - strip the leading path and look only at the basename
> - only look at files which have tNNNN- (where N stand for a digit) in the name
> Signed-off-by: Torsten Bögershausen <tbo...@web.de>
> ---

Yeah, I think this is fine. Though note that we already have Felipe's
patch to just set TEST_LINT explicitly, so I think it is a non-issue

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to